Re: [Jack-Devel] sdl2 jack support

On Fri, Oct 11, 2013 at 3:02 AM, Patrick Shirkey
<[hidden]> wrote:
>
> On Fri, October 11, 2013 3:10 pm, Tristan Matthews wrote:
>> On Wed, Oct 9, 2013 at 10:38 AM, Patrick Shirkey
>> <[hidden]
>>> wrote:
>>
>>> Hi,
>>>
>>> Does anyone here want to take a look at this patch for libsdl2 ?
>>>
>>
>> Sure.
>>
>>
>>>
>>> http://boosthardware.com/sdl-jack-patch.tar.bz2
>>>
>>> It compiles but is untested at this point.
>>>
>>> Feedback appreciated as this might end up being used by a lot of apps on
>>> Valves SteamOS and various other open source games.
>>>
>>> The bulk of the code comes from this thread
>>> https://forums.libsdl.org/viewtopic.php?t=5682
>>>
>>> I just hooked it up to the make scripts and got it to compile with the
>>> latest master branch.
>>>
>>> The code looks good to me but it's possible that the original author did
>>> not write the most efficient methods.
>>>
>>
>> There's definitely some cleanup to do to make this patch fit with SDL's
>> coding style, as well as some pruning of copy/pasted cruft. Most
>> importantly testing. I'd be happy to take a crack at this over the next
>> few
>> days.
>>
>
> We will need a demo app that loads the jack module too.
>
> Maybe simplemixer will be a useful for that:
>
> http://olofson.net/examples.html

I've created a ticket and attached a revised patch to it here:
https://bugzilla.libsdl.org/show_bug.cgi?id=2163

-- 
Tristan Matthews
web: http://tristanswork.blogspot.com

1382160481.15219_0.ltw:2, <CAN8HRDkzc0pFTxXHEC7R3iwoF7mD8qKyTUC_4F2XDaWHuatQAg at mail dot gmail dot com>