Re: [Jack-Devel] [PATCH 14/16] Removed re-enabled the exit command in the not_overwriting configure.ac section.

PrevNext  Index
DateFri, 14 Feb 2014 11:53:02 +0100
From Adrian Knoth <[hidden] at drcomp dot erfurt dot thur dot de>
ToMatt Flax <[hidden] at flatmax dot org>, [hidden] at lists dot jackaudio dot org
In-Reply-ToMatt Flax Re: [Jack-Devel] [PATCH 14/16] Removed re-enabled the exit command in the not_overwriting configure.ac section.
On 02/14/14 11:50, Matt Flax wrote:

> I will look into rebase and fixup to work out how to remove the patches
> of patches unpatching sketches :)

Yeah, it's pretty easy:

    $ git checkout -b for-upstream
    $ git rebase -i last_good_commit
    (use fixup everywhere)

and there you are: a nicely formatted patch. ;)


> Do you think I should email them to the list or do a pull request for
> review ?

Pull requests would be better, so we can use github's inline comments.
You can even update pull requests which removes the burden from creating
the patch over and over again.


Cheers
PrevNext  Index

1392375189.5009_0.ltw:2,a <52FDF58E.8090303 at drcomp dot erfurt dot thur dot de>