Re: [Jack-Devel] JACK2 for Android!

Le 24 oct. 2013 à 14:21, 김정연 <[hidden]> a écrit :

> Hello,
> 
> I have news of JACK2 in android world!
> 
> Recently, Samsung released professional audio sdk on android platform which based on JACK2. 
> It is a part of latest Samsung Mobile SDK:
> http://developer.samsung.com/samsung-mobile-sdk#professional-audio
> 
> Source code of JACK2 was retrieved from Samsung's Open Source Release Center(OSRC) at http://opensource.samsung.com/. You can find current repository & more information at below link:
> https://github.com/KimJeongYeon/jack2_android
> 
> Additionally, SAMSUNG DEVELOPER CONFERENCE(October 28-29, 2013) will be held in San Francisco that one of sessions prepared to introduced professional audio on Samsung's android mobile products:
> http://www.samsungdevcon.com/
> Session : "Leveraging the Latest Features in Professional Audio Framework in Your App"
> 
> Thanks,
> KimJeongYeon
> 
> Jack-Devel mailing list
> [hidden]
> http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org


Congratulations for the release!

I read also your code and have somme comments:

- you seems to use a lot of #if (JACK_ANDROID) at several places in the*generic* part of the code. This could be probably cleanup a bit and better moved in android specific files.

-  your JackGoldfishDriver class is defined as a subclass of JackTimedDriver. I don't this this is necessary since your driver is simply a "blocking" one (that is using booking read/write specific API calls right). Then having JackGoldfishDriver be a subclass of JackAudioDriver should be enough

- what are your plan concerning reintegration of the android specific code in the official jack2 tree? This would be great of course, I can help cleanup up the code a bit to facilitate this, if you need to.

Stéphane

1383051860.3003_0.ltw:2, <2CF216CD-6F17-4215-80D2-6CC83467692E at grame dot fr>